Build: #168 failed Changes by Gary Russell

Build result summary

Details

Completed
Duration
4 minutes
Labels
None
Agent
bamboo-02.af.pivotal.io
Revision
9f7b65ba273caf4df5311479f1163fd34ffebf1c 9f7b65ba273caf4df5311479f1163fd34ffebf1c
Total tests
759
Fixed in
#169 (Changes by Artem Bilan)

Responsible

Code commits

Author Commit Message Commit date
Gary Russell Gary Russell 9f7b65ba273caf4df5311479f1163fd34ffebf1c 9f7b65ba273caf4df5311479f1163fd34ffebf1c GH-905: Fix @RabbitListener Thread Names
Fixes https://github.com/spring-projects/spring-amqp/issues/905

Default container thread names are based on the bean name. `@RabbitListener`
containers are not beans; use `getListenerId()` instead (which falls back
to bean name for other containers).

**cherry-pick to all supported branches**

(cherry picked from commit 5f4c60a969e42b9b89b6dbb758b62ebfe970f295)

# Conflicts:
#        spring-rabbit/src/test/java/org/springframework/amqp/rabbit/annotation/EnableRabbitIntegrationTests.java

# Conflicts:
#        spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractMessageListenerContainer.java

Tests

New test failures 1
Status Test View job Duration
Collapse Failed EnableRabbitIntegrationTests autoDeclare History
Default Job < 1 sec
org.junit.ComparisonFailure: org.junit.ComparisonFailure: expected:<FOO[threadName]r-1> but was:<FOO[SimpleAsyncTaskExecuto]r-1>
org.junit.ComparisonFailure: expected:<FOO[threadName]r-1> but was:<FOO[SimpleAsyncTaskExecuto]r-1>
	at org.junit.Assert.assertEquals(Assert.java:115)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.springframework.amqp.rabbit.annotation.EnableRabbitIntegrationTests.autoDeclare(EnableRabbitIntegrationTests.java:217)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(48 more lines...)

JIRA issues

IssueDescriptionStatus
Unknown Issue TypeGH-905Could not obtain issue details from JIRA