Sonar Build (Master) - https://sonar.spring.io/dashboard/index/org.springframework.amqp:spring-amqp-dist

Build: #2482 was successful Scheduled with changes by Gary Russell

Build result summary

Details

Completed
Duration
7 minutes
Labels
None
Agent
bamboo-03.af.pivotal.io
Revision
78b1eaee79332f2df3b27176ffb4ac4d1e3a4f21 78b1eaee79332f2df3b27176ffb4ac4d1e3a4f21
First to pass since
#2481 (Scheduled – )

Code commits

Author Commit Message Commit date
Gary Russell Gary Russell 78b1eaee79332f2df3b27176ffb4ac4d1e3a4f21 78b1eaee79332f2df3b27176ffb4ac4d1e3a4f21 Fix race in test
https://build.spring.io/browse/AMQP-SONAR-2481/

With a short timeout, the consumer might not receive the `consumeOk` in time.

```
org.springframework.amqp.rabbit.core.ConsumeOkNotReceivedException: Blocking receive, consumer failed to consume: TemplateConsumer [channel=Cached Rabbit Channel: PublisherCallbackChannelImpl: AMQChannel(amqp://guest@127.0.0.1:5672/,1), conn: Proxy@374f01d1 Shared Rabbit Connection: SimpleConnection@b347172 [delegate=amqp://guest@127.0.0.1:5672/, localPort= 60288], consumerTag=amq.ctag-Ss7YrnvpFtQfF00vlzQ1qQ]
        at org.springframework.amqp.rabbit.core.RabbitTemplate.createConsumer(RabbitTemplate.java:2584)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.consumeDelivery(RabbitTemplate.java:1341)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.lambda$receive$5(RabbitTemplate.java:1155)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.invokeAction(RabbitTemplate.java:2121)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.doExecute(RabbitTemplate.java:2080)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.execute(RabbitTemplate.java:2033)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.execute(RabbitTemplate.java:2013)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.receive(RabbitTemplate.java:1154)
        at org.springframework.amqp.rabbit.core.RabbitTemplate.receiveAndConvert(RabbitTemplate.java:1199)
        at org.springframework.amqp.rabbit.core.RabbitTemplateIntegrationTests.testReceiveTimeoutRequeue(RabbitTemplateIntegrationTests.java:403)
```
Gary Russell Gary Russell 1d290a3a45ec6f6135f7fbd02663c96e04d8dcbc 1d290a3a45ec6f6135f7fbd02663c96e04d8dcbc Reduce factory method complexity
- proposed new model for non-null property propagation

* Polishing - PR comments; extract to utility and provide chaining.

* Javadocs for INSTANCE.

* Fix Javadocs (checkstyle)

* Configure direct containers the same way.

* Returning this is more efficient than INSTANCE.