Build #125

Build plan for MS Windows

Build result summary

Details

Completed
Duration
55 minutes
Labels
None
Revision
b19998a40ad02f368d64816193ae46c63fe1ad30 b19998a40ad02f368d64816193ae46c63fe1ad30
Total tests
3738
Failing since
#124 (Changes by Mahmoud Ben Hassine)
Fixed in
#129 (Changes by Mahmoud Ben Hassine)

Responsible

Code commits

Author Commit Message Commit date
Mahmoud Ben Hassine Mahmoud Ben Hassine b19998a40ad02f368d64816193ae46c63fe1ad30 b19998a40ad02f368d64816193ae46c63fe1ad30 Fix KafkaItemReader
This commit introduces the changes discussed in PR #664:

* Remove `OffsetsProvider`: We only need offsets to be retrieved from
the execution context in a restart scenario
* Make the reader inherit from `AbstractItemStreamItemReader` instead
of `AbstractItemCountingItemStreamItemReader`. With Kafka offsets, item
counting does not make sense
* Remove `assignTimeoutProvider`. A configurable poll timeout with
a default value is enough.
* Update the constructor of the reader to accept consumer properties,
a topic name and a list of partitions instead of leaking Kafka APIs like
`TopicPartition` and `ConsumerFactory`.

Resolves BATCH-2764
Mathieu Ouellet <mat_ouel@hotmail.com> Mathieu Ouellet <mat_ouel@hotmail.com> 77c9b74673ada1e485c563cf80d1f136d07bd334 77c9b74673ada1e485c563cf80d1f136d07bd334 Add KafkaItemReader
Resolves BATCH-2764

Tests

New test failures 2
Status Test View job Duration
Collapse Failed DecisionStepTests testDecisionAfterSplit History
Default Job < 1 sec
java.lang.AssertionError: java.lang.AssertionError: expected:<COMPLETED> but was:<FAILED>
java.lang.AssertionError: expected:<COMPLETED> but was:<FAILED>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.springframework.batch.core.jsr.step.DecisionStepTests.testDecisionAfterSplit(DecisionStepTests.java:111)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
(45 more lines...)
Collapse Failed KafkaItemReaderTests testReadFromMultiplePartitionsAfterRestart History
Default Job 3 secs
java.lang.AssertionError: java.lang.AssertionError: 
Expected: iterable over ["val4", "val6", "val7"] in any order
     but: Not matched: null
java.lang.AssertionError: 
Expected: iterable over ["val4", "val6", "val7"] in any order
     but: Not matched: null
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
(51 more lines...)
Fixed tests 2
Status Test Failing since View job Duration
Successful SplitInterruptedJobParserTests testSplitInterrupted History
Failing since build #124 (Changes by Mahmoud Ben Hassine) Default Job < 1 sec
Successful JsrSplitParsingTests test History
Failing since build #124 (Changes by Mahmoud Ben Hassine) Default Job < 1 sec

Jira issues

IssueDescriptionStatus
Unknown Issue TypeBATCH-2764Could not obtain issue details from Jira