Build #186

Plan to test the build on a specific branch

Build: #186 failed Scheduled with changes by 3 people

Build result summary

Details

Completed
Duration
4 minutes
Labels
None
Agent
bamboo-22.af.pivotal.io
Revision
f26165e764c1e4b25a3778eafa9783bea7d73693 f26165e764c1e4b25a3778eafa9783bea7d73693
Total tests
3464
Fixed in
#187 (Scheduled)

Tests

Responsible

Code commits

Author Commit Message Commit date
Mahmoud Ben Hassine Mahmoud Ben Hassine f26165e764c1e4b25a3778eafa9783bea7d73693 f26165e764c1e4b25a3778eafa9783bea7d73693 Polish bd53168ddb613aa5a5f8bc550f20a828ce3cf17d
David Turanski <dturanski@pivotal.io> David Turanski <dturanski@pivotal.io> bd53168ddb613aa5a5f8bc550f20a828ce3cf17d bd53168ddb613aa5a5f8bc550f20a828ce3cf17d Implement AvroItemReader and AvroItemWriter
Resolves BATCH-2833
Mahmoud Ben Hassine Mahmoud Ben Hassine 872845cae8f5922c1b8747c13c3a3b9d4956e8bc 872845cae8f5922c1b8747c13c3a3b9d4956e8bc Improve the lookup for running job executions in CommandLineJobRunner
Before this commit, getting the running job executions loaded
all job executions from the database and filtered them in-memory.

This commit uses `JobExplorer#findRunningJobExecutions` which issues
a query that does the filtering on the database side. This change
considerably improves the performance of stopping a job.

Resolves BATCH-2422
Michael Minella Michael Minella fda70ccbcbb95bad780c4d86aa34764567f88e3c fda70ccbcbb95bad780c4d86aa34764567f88e3c Fixed integration test breaking build
Mahmoud Ben Hassine Mahmoud Ben Hassine 7c1fbede1b53f1f6e00f6dd1dc614d1a99faf09c 7c1fbede1b53f1f6e00f6dd1dc614d1a99faf09c Add new methods to get the last job instance/execution in JobInstance/JobExecution DAOs
Before this commit, getting the last job instance/execution required to
load all job instances/executions from the database and filter them
on the client side in memory.

This commit introduces new methods that use database queries to get
the last job instance/execution without the need to load all job
instances/executions. This change improves memory consumption as well as
the performance of starting the next instance of a job.

Resolves BATCH-1784

Tests

New test failures 1
Status Test View job Duration
Collapse Failed KafkaItemReaderTests testReadFromMultiplePartitionsAfterRestart History
Default Job 3 secs
java.lang.AssertionError: java.lang.AssertionError: 
Expected: iterable over ["val4", "val6", "val7"] in any order
     but: Not matched: null
java.lang.AssertionError: 
Expected: iterable over ["val4", "val6", "val7"] in any order
     but: Not matched: null
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
(51 more lines...)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeBATCH-1784Could not obtain issue details from Jira
Unknown Issue TypeBATCH-2422Could not obtain issue details from Jira
Unknown Issue TypeBATCH-2833Could not obtain issue details from Jira