Build #41

Build result summary

Details

Completed
Duration
25 seconds
Labels
None
Revision
9fe53e119002eb6b8d63cb3a6961b31592d6dd4d 9fe53e119002eb6b8d63cb3a6961b31592d6dd4d
Total tests
3
Fixed in
#42 (Changes by Mark Paluch and Spring Operator <spring-operator@users.noreply.github.com>)

Tests

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Spring Operator <spring-operator@users.noreply.github.com> Spring Operator <spring-operator@users.noreply.github.com> 9fe53e119002eb6b8d63cb3a6961b31592d6dd4d 9fe53e119002eb6b8d63cb3a6961b31592d6dd4d URL Cleanup
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.

* http://192.168.11.11:8200/ (ConnectTimeoutException) with 4 occurrences migrated to:
  https://192.168.11.11:8200/ ([https](https://192.168.11.11:8200/) result ConnectTimeoutException).

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* http://cloud.spring.io/spring-cloud-connectors/spring-cloud-connectors.html with 1 occurrences migrated to:
  https://cloud.spring.io/spring-cloud-connectors/spring-cloud-connectors.html ([https](https://cloud.spring.io/spring-cloud-connectors/spring-cloud-connectors.html) result 200).
* http://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html with 2 occurrences migrated to:
  https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html ([https](https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-external-config.html) result 200).
* http://repo.spring.io/libs-snapshot with 1 occurrences migrated to:
  https://repo.spring.io/libs-snapshot ([https](https://repo.spring.io/libs-snapshot) result 302).

# Ignored
These URLs were intentionally ignored.

* http://localhost:10334/ with 1 occurrences
* http://localhost:10334/?token=foo&backend.transit=cf/transit&shared_backend.generic=cf/secret with 1 occurrences
* http://localhost:8200 with 3 occurrences
* http://localhost:8200?token=my-token with 1 occurrences
* http://localhost:8200?token=my-token&backend.generic=cf/secret&backend.transit=cf/transit&shared_backend=space=cf/space with 2 occurrences

Tests

New test failures 1
Status Test View job Duration
Collapse Failed VaultServiceInfoCreatorUnitTests shouldCreateServiceInfoWithMultipleBackends History
Default Job < 1 sec
org.junit.ComparisonFailure: org.junit.ComparisonFailure: expected:<"http[]"> but was:<"http[s]">
org.junit.ComparisonFailure: expected:<"http[]"> but was:<"http[s]">
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at io.pivotal.spring.cloud.vault.cloudfoundry.VaultServiceInfoCreatorUnitTests.shouldCreateServiceInfoWithMultipleBackends(VaultServiceInfoCreatorUnitTests.java:76)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(46 more lines...)