Build #37

Build: #37 failed Changes by Brian Clozel

Build result summary

Details

Completed
Duration
1 minute
Labels
None
Agent
bamboo-2k16-00
Revision
d44250c81c205bb884bc164c5258c0642b198662 d44250c81c205bb884bc164c5258c0642b198662
Total tests
208
Failing since
#2 (Manual run by Stephane Maldini)
Fixed in
#41 (Manual run by Stephane Maldini)

Responsible

This build has been failing since #2
No one has taken responsibility

Code commits

Author Commit Message Commit date
Brian Clozel Brian Clozel d44250c81c205bb884bc164c5258c0642b198662 d44250c81c205bb884bc164c5258c0642b198662 Don't send chunked transfer for DELETE requests
This commit adds `DELETE` requests to the list of HTTP methods which
shouldn't send `Transfer-Encoding: chunked` request headers by default.

The HTTP specification states that for `GET`, `HEAD` and `DELETE`
requests, a payload has "no defined semantics" and "might cause existing
implementations to reject the request".
See https://tools.ietf.org/html/rfc7231#section-4.3.5

This commit aligns the `DELETE` behavior on other, similar HTTP methods.

Tests

New test failures 1
Status Test View job Duration
Collapse Failed WebsocketTest simpleSubprotocolServerNotSupported History
Netty < 1 sec
java.lang.AssertionError: java.lang.AssertionError: expectation "expectErrorMessage" failed (expected error message: "Invalid subprotocol. Actual: null. Expected one of: SUBPROTOCOL,OTHER"; actual message: An existing connection was forcibly closed by the remote host)
java.lang.AssertionError: expectation "expectErrorMessage" failed (expected error message: "Invalid subprotocol. Actual: null. Expected one of: SUBPROTOCOL,OTHER"; actual message: An existing connection was forcibly closed by the remote host)
	at reactor.test.DefaultStepVerifierBuilder.failPrefix(DefaultStepVerifierBuilder.java:2171)
	at reactor.test.DefaultStepVerifierBuilder.fail(DefaultStepVerifierBuilder.java:2167)
	at reactor.test.DefaultStepVerifierBuilder.lambda$expectErrorMessage$6(DefaultStepVerifierBuilder.java:272)
	at reactor.test.DefaultStepVerifierBuilder$SignalEvent.test(DefaultStepVerifierBuilder.java:1909)
	at reactor.test.DefaultStepVerifierBuilder$DefaultVerifySubscriber.onSignal(DefaultStepVerifierBuilder.java:1270)
	at reactor.test.DefaultStepVerifierBuilder$DefaultVerifySubscriber.onExpectation(DefaultStepVerifierBuilder.java:1215)
(56 more lines...)
Existing test failures 7
Status Test Failing since View job Duration
reactor.core.Exceptions$ReactiveException: reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
	at reactor.core.Exceptions.propagate(Exceptions.java:294)
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:122)
	at reactor.core.publisher.Mono.block(Mono.java:1183)
	at reactor.ipc.netty.http.HttpErrorTests.test(HttpErrorTests.java:53)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(57 more lines...)
org.spockframework.runtime.WrongExceptionThrownError: Expected exception of type 'reactor.ipc.netty.http.client.HttpClientException', but got 'reactor.core.Exceptions$ReactiveException'
Expected exception of type 'reactor.ipc.netty.http.client.HttpClientException', but got 'reactor.core.Exceptions$ReactiveException'
	at org.spockframework.lang.SpecInternals.checkExceptionThrown(SpecInternals.java:79)
	at org.spockframework.lang.SpecInternals.thrownImpl(SpecInternals.java:66)
	at reactor.ipc.netty.http.HttpSpec.http error with requests from clients(HttpSpec.groovy:179)
Caused by: reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
	at reactor.core.Exceptions.propagate(Exceptions.java:294)
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:122)
(17 more lines...)
reactor.core.Exceptions$ReactiveException: reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
	at reactor.core.Exceptions.propagate(Exceptions.java:294)
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:122)
	at reactor.core.publisher.Mono.block(Mono.java:1183)
	at reactor.ipc.netty.http.client.WebsocketTest.anySubprotocolSelectsFirstClientProvided(WebsocketTest.java:331)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(58 more lines...)
reactor.core.Exceptions$ReactiveException: reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
	at reactor.core.Exceptions.propagate(Exceptions.java:294)
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:122)
	at reactor.core.publisher.Mono.block(Mono.java:1183)
	at reactor.ipc.netty.http.client.WebsocketTest.noSubprotocolSelected(WebsocketTest.java:307)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(58 more lines...)
reactor.core.Exceptions$ReactiveException: reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
reactor.core.Exceptions$ReactiveException: java.io.IOException: An existing connection was forcibly closed by the remote host
	at reactor.core.Exceptions.propagate(Exceptions.java:294)
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:122)
	at reactor.core.publisher.Mono.block(Mono.java:1183)
	at reactor.ipc.netty.http.client.WebsocketTest.simpleSubprotocolSelected(WebsocketTest.java:284)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(58 more lines...)
org.junit.ComparisonFailure: org.junit.ComparisonFailure: expected:<[fals]e> but was:<[tru]e>
org.junit.ComparisonFailure: expected:<[fals]e> but was:<[tru]e>
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at reactor.ipc.netty.options.ClientOptionsTest.useProxy(ClientOptionsTest.java:104)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(40 more lines...)
java.lang.AssertionError: java.lang.AssertionError: latch was counted down:1
java.lang.AssertionError: latch was counted down:1
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at reactor.ipc.netty.tcp.TcpClientTests.connectionWillRetryConnectionAttemptWhenItFails(TcpClientTests.java:239)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(40 more lines...)
Fixed tests 1
Status Test Failing since View job Duration
Successful WebsocketTest simpleTest History
Failing since build #36 (Changes by Violeta Georgieva) Netty < 1 sec