Build #2,371

Build result summary

Details

Completed
Duration
5 minutes
Labels
None
Agent
bamboo-13.af.pivotal.io
Revision
2cbc53d419e284de9c203ad511705b3a14714c19 2cbc53d419e284de9c203ad511705b3a14714c19
Total tests
4969
Fixed in
#2372 (Manual run by Simon Basle)

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Narendra Pathai <narendra.pathai@gmail.com> Narendra Pathai <narendra.pathai@gmail.com> 2cbc53d419e284de9c203ad511705b3a14714c19 2cbc53d419e284de9c203ad511705b3a14714c19 fix #1453 Converted eager toString call from index operator to lazy
Due to use of Objects.requireNonNull(Object, String) variant, toString
for each element that was passing through the operator was evaluated
eagerly.

Rather than using Supplier<String> variant of Objects.requireNonNull()
which would have created Supplier instances unnecessarily, used
traditional null check. As the check for null safe index mapping was
repeated thrice in FluxIndex, created a NullSafeIndexMapper class which
wraps actual indexMapper and provides null safe check.
NullSafeIndexMapper instance is created once from the constructor.

Tests

New test failures 1
Status Test View job Duration
Collapse Failed FluxFlatMapTest errorModeContinueInternalErrorStopStrategyAsync History
Core < 1 sec
java.lang.AssertionError: java.lang.AssertionError: Expected exactly 1 dropped errors, 0 found.
java.lang.AssertionError: Expected exactly 1 dropped errors, 0 found.
	at reactor.test.ErrorFormatter.assertionError(ErrorFormatter.java:105)
	at reactor.test.DefaultStepVerifierBuilder$DefaultStepVerifierAssertions.satisfies(DefaultStepVerifierBuilder.java:1745)
	at reactor.test.DefaultStepVerifierBuilder$DefaultStepVerifierAssertions.hasDroppedErrors(DefaultStepVerifierBuilder.java:1837)
	at reactor.core.publisher.FluxFlatMapTest.errorModeContinueInternalErrorStopStrategyAsync(FluxFlatMapTest.java:1608)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(43 more lines...)