Build #2,559

Build: #2559 failed Changes by Sergei Egorov

Build result summary

Details

Completed
Duration
4 minutes
Labels
None
Agent
bamboo-19.af.pivotal.io
Revision
a4523ad472f15e1f50d506c41d321d6a7d302150 a4523ad472f15e1f50d506c41d321d6a7d302150
Total tests
5080
Fixed in
#2560 (Manual run by Sergei Egorov)

Tests

Responsible

Code commits

Author Commit Message Commit date
Sergei Egorov Sergei Egorov a4523ad472f15e1f50d506c41d321d6a7d302150 a4523ad472f15e1f50d506c41d321d6a7d302150 Record executor service metrics to Micrometer (#1795)
Since we were ignoring the result of `ExecutorServiceMetrics.monitor`,
we were not reporting the execution times of tasks submitted to `ExecutorServices`.

These metrics are super helpful to detect thread starvation
(by analysing executor_seconds_max, for instance).

This change make it instrument every `Runnable` the same way Micrometer does.

Tests

New test failures 1
Status Test View job Duration
Collapse Failed FluxFlatMapTest errorModeContinueInternalErrorStopStrategyAsync History
Core < 1 sec
java.lang.AssertionError: java.lang.AssertionError: Expected exactly 1 dropped errors, 0 found.
java.lang.AssertionError: Expected exactly 1 dropped errors, 0 found.
	at reactor.test.MessageFormatter.assertionError(MessageFormatter.java:115)
	at reactor.test.DefaultStepVerifierBuilder$DefaultStepVerifierAssertions.satisfies(DefaultStepVerifierBuilder.java:1756)
	at reactor.test.DefaultStepVerifierBuilder$DefaultStepVerifierAssertions.hasDroppedErrors(DefaultStepVerifierBuilder.java:1868)
	at reactor.core.publisher.FluxFlatMapTest.errorModeContinueInternalErrorStopStrategyAsync(FluxFlatMapTest.java:1608)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
(43 more lines...)