Build #2,710

Build: #2710 was successful Changes by Simon Basle

Build result summary

Details

Completed
Duration
9 minutes
Labels
None
Agent
bamboo-12.af.pivotal.io
Revision
ae86602c5d37658b8e0bea8323ea3ef66a9211ec ae86602c5d37658b8e0bea8323ea3ef66a9211ec
Total tests
5764
Successful since
#2709 ()

Tests

Code commits

Author Commit Message Commit date
Simon Basle Simon Basle ae86602c5d37658b8e0bea8323ea3ef66a9211ec ae86602c5d37658b8e0bea8323ea3ef66a9211ec fix #1973 Resolve a race that prevent decrement of REMAINING_TASK
When the active worker becomes inactive and picks a deferred worker
to serve, but at the same time that deferred worker is cancelled or
disposed, the later can be gone from the parent's pool (due to the
former polling).

The issue is that the decrementing of REMAINING_TASK was guarded
by a successful removal of the deferred worker from the parent,
which in the race is already removed and thus returns false.

The decrement must be done unconditionally at this step to fix
the issue.