Build: #12 failed Changes by Simon Baslé <simon.basle@gmail.com>

Build result summary

Details

Completed
Duration
2 minutes
Labels
None
Agent
bamboo-12.af.pivotal.io
Revision
e7ea787e433cd33d89a84ee4b4ffc283368fa9c9 e7ea787e433cd33d89a84ee4b4ffc283368fa9c9
Total tests
247
Fixed in
#14 (Manual run by Simon Basle)

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Simon Baslé <simon.basle@gmail.com> Simon Baslé <simon.basle@gmail.com> e7ea787e433cd33d89a84ee4b4ffc283368fa9c9 e7ea787e433cd33d89a84ee4b4ffc283368fa9c9 fix #22 Add InstrumentedPool, with gauge-compatible metrics API
The idea in this PR is to expose internal state of the pool through a PoolMetrics API (similar to what is done with PooledRef, a view of the Pool).

It also exposes 2 configuration elements (max size and max pending size).

The former UNBOUNDED allocation strategy must now be instantiated independently
in order to keep track of current allocation count for the benefit of these gauges.

Tests

New test failures 1
Status Test View job Duration
Collapse Failed CommonPoolTest smokeTestAsyncLifo(Function)[2] History
Reactor Pool 2 secs
java.lang.AssertionError: java.lang.AssertionError: 
Expected size:<3> but was:<2> in:
<[PooledRef{poolable=PoolableTest{id=5, used=0/2}, lifeTime=0ms, idleTime=0ms, acquireCount=1},
    PooledRef{poolable=PoolableTest{id=6, used=0/2}, lifeTime=0ms, idleTime=0ms, acquireCount=1}]>
java.lang.AssertionError: 
Expected size:<3> but was:<2> in:
<[PooledRef{poolable=PoolableTest{id=5, used=0/2}, lifeTime=0ms, idleTime=0ms, acquireCount=1},
    PooledRef{poolable=PoolableTest{id=6, used=0/2}, lifeTime=0ms, idleTime=0ms, acquireCount=1}]>
(118 more lines...)