Build #160

Build: #160 was successful Changes by Simon Baslé <sbasle@vmware.com>

Build result summary

Details

Completed
Duration
7 minutes
Labels
None
Agent
bamboo-18.af.pivotal.io
Revision
f4271fa6115695b41e1f38b516ce003b6e82ffd4 f4271fa6115695b41e1f38b516ce003b6e82ffd4
Total tests
359
Successful since
#154 ()

Tests

  • 0 New failures
  • 0 Existing failures
  • 0 Fixed

Code commits

Author Commit Message Commit date
Simon Baslé <sbasle@vmware.com> Simon Baslé <sbasle@vmware.com> f4271fa6115695b41e1f38b516ce003b6e82ffd4 f4271fa6115695b41e1f38b516ce003b6e82ffd4 Merge #129 into 0.2.4
japicmp is still baselining against 0.1.x, but now the latest release:
0.1.9.RELEASE.
Simon Baslé <sbasle@vmware.com> Simon Baslé <sbasle@vmware.com> 50e173045bc5521f818943788f41b4c3cbe2abcf m 50e173045bc5521f818943788f41b4c3cbe2abcf Implementation review, make a few small improvements... (#129)
This commit fixes a few low hanging fruits in the current pool
implementation:

 - Remove PENDING_COUNT and rely on `Queue#size()` directly instead
 - isDisposed also checks IDLE_RESOURCES is null
 - Remove WIP lazySets to prevent re-entry in terminal state
 - In drain loop, return slot if no borrower and invalidate slot
   if pool disposed. These case are protective against polling
   an unexpected null in the drain loop, although the conditional
   branches are reviewing the actual queue sizes.
 - In tests, make the switch to new RaceTestUtils methods
 - Ensure japicmp compares with the latest release as baseline

This commit also adds a few remaining TODOs.