Build #2,321

Build Spring Cloud Data Flow

Build: #2321 failed Changes by Christian Tzolov

Stages & jobs

  1. Default Stage

  2. Build Docker Images and upload

Build result summary

Details

Completed
Duration
7 minutes
Labels
None
Revision
3f0737c9e5549aa7746c91675cde9a7698429e5e 3f0737c9e5549aa7746c91675cde9a7698429e5e
Total tests
1247
Fixed in
#2325 (Manual run by Ilayaperumal Gopinathan)

Tests

Responsible

Code commits

Author Commit Message Commit date
Christian Tzolov Christian Tzolov 3f0737c9e5549aa7746c91675cde9a7698429e5e 3f0737c9e5549aa7746c91675cde9a7698429e5e Deprecate Classic Mode (Part 1)
  Related to #2548

  - Replace all occurrences of AppRegistry by AppRegistryCommon or AppRegistyrService. This moves all app registration (including tasks) from UriAppRegistry to DefaultAppRegistryService
  - The AbstractShellIntegrationTest and therefore all CommandsXXX tests spin an embedded SCDF server - Had to mock the skipperClient and add default mode About response
  - In DataFlowControllerAutoConfiguration#skipperClient bean factory remove the Jackson2HalModule() (see https://pivotal.slack.com/archives/G49UPQAP8/p1541431130391100 and https://pivotal.slack.com/archives/C055XJPLR/p1540810022013200 )
  - Add optional StreamDefinitionRepository and StreamService dependencies for SkipperAppRegistryController. Later are used for app unregister validation but are not present for stream feature disabled!  It is awkward that Apps should depend on Streams. This dependencies should be other way around.  This also manifestations the split app state, split between SCDF and Skipper
  - Remove all Classic Mode bean definitions from DataFlowControllerAutoConfiguration and TestDependecies
  - Remove Skipper feature and all its occurrences and checks. Now all previous skipper related configurations are subject of the Stream Feature policies.
  - The StreamControllerTests#testDeployWithWildcardProperties demonstrates how to use the skipperClient mock and UploadRequest and InstallRequest to verify the Stream Creation and Deployment behavior without relying on local app deployer
  - Removed classes:
     AppDeployerStreamDeployer, AppDeployerStreamDeployerTests
     AppDeployerStreamService
     AppDeployerStreamServiceTests
     AppRegistry, AppRegistryTests
     AppRegistryController, AppRegistryControllerTests
     ClassicAppRegistryCommands, ClassicAppRegistryCommandsTests, ClassicStreamCommands
     ConditionalOnSkipperDisabled, ConditionalOnSkipperEnabled
     DataFlowMode, IncompatibleDataFlowMode
     org.springframework.cloud.dataflow.shell.command.classic Package
     RdbmsUriRegistry, RdbmsUriRegistryTests
     RedisUriRegistry

- Resolve Jackson2HalModule configuration
- Remove redundant,  classic-mode classes.
- Improve test coverage.
- mock skipper client for tests

Configuration changes

Some of the jobs or stages referenced by this result no longer exist.

Tests

New test failures 1
Status Test View job Duration
Collapse Failed ShellCommandsTests testMultiFileCommandOrderPreserved History
Build and install SCDF 2 secs 
java.lang.AssertionError: Registry should be empty
Expected: an empty collection
     but: <[AppRegistration{name='log', type='sink', version='1.0.0.BUILD-SNAPSHOT', uri=maven://org.springframework.cloud.stream.app:log-sink-rabbit:1.0.0.BUILD-SNAPSHOT, metadataUri=null}]>
java.lang.AssertionError: 
Registry should be empty
Expected: an empty collection
     but: <[AppRegistration{name='log', type='sink', version='1.0.0.BUILD-SNAPSHOT', uri=maven://org.springframework.cloud.stream.app:log-sink-rabbit:1.0.0.BUILD-SNAPSHOT, metadataUri=null}]>
	at org.springframework.cloud.dataflow.shell.command.ShellCommandsTests.testMultiFileCommandOrderPreserved(ShellCommandsTests.java:83)