Build Spring Cloud Data Flow

Build: #3436 failed Rebuilt by Ilayaperumal Gopinathan

Build result summary

Details

Completed
Duration
5 minutes
Labels
None
Agent
bamboo-20.af.pivotal.io
Revision
1ce362a23679a54ef24241c503de0078f4f92f1c 1ce362a23679a54ef24241c503de0078f4f92f1c
Total tests
743
Fixed in
#3439 (Changes by Janne Valkealahti)
Number of retries
1

Tests

Responsible

Code commits

Author Commit Message Commit date
Janne Valkealahti Janne Valkealahti 1ce362a23679a54ef24241c503de0078f4f92f1c 1ce362a23679a54ef24241c503de0078f4f92f1c Support reusing deployer props and command-line args in tasks
- Bring over analyzer and diff utils from a skipper order
  to see what has been changed in a task launches.
- PropertiesDiff impl copied over from skipper has been enhanced
  to support understanding of a deletion of a property. This now
  means that we understand a common property(not changed), changed
  property, added property, removed(doesn't exist in a new set) and
  deleted property(value is effectively missing).
- Deleted property vs removed property has a distiction in a sense
  that we then know that if user explicitely deleted it should not
  get back while removed property should get back to a new launch.
- Change in TaskAppDeploymentRequestCreator to stash all deploy props
  so that we know what to resurrect when app specific props were passed
  in via deploy props.
- DefaultTaskExecutionService has been modified(mostly executeTask has
  been partially rewritten to reuse props and args).
- Fixes #3555

Tests

New test failures 1
Status Test View job Duration
Collapse Failed DefaultTaskJobServiceTests testRestart History
Build and install SCDF < 1 sec
java.lang.AssertionError
	at org.springframework.cloud.dataflow.server.service.impl.DefaultTaskJobServiceTests.testRestart(DefaultTaskJobServiceTests.java:138)