Build #2,321

Build Spring Cloud Data Flow

Build: #2321 failed

Job: Build and install SCDF failed

Stages & jobs

  1. Default Stage

  2. Build Docker Images and upload

Code commits

Git

  • Christian Tzolov

    Christian Tzolov 3f0737c9e5549aa7746c91675cde9a7698429e5e

    Deprecate Classic Mode (Part 1)
      Related to #2548

      - Replace all occurrences of AppRegistry by AppRegistryCommon or AppRegistyrService. This moves all app registration (including tasks) from UriAppRegistry to DefaultAppRegistryService
      - The AbstractShellIntegrationTest and therefore all CommandsXXX tests spin an embedded SCDF server - Had to mock the skipperClient and add default mode About response
      - In DataFlowControllerAutoConfiguration#skipperClient bean factory remove the Jackson2HalModule() (see https://pivotal.slack.com/archives/G49UPQAP8/p1541431130391100 and https://pivotal.slack.com/archives/C055XJPLR/p1540810022013200 )
      - Add optional StreamDefinitionRepository and StreamService dependencies for SkipperAppRegistryController. Later are used for app unregister validation but are not present for stream feature disabled!  It is awkward that Apps should depend on Streams. This dependencies should be other way around.  This also manifestations the split app state, split between SCDF and Skipper
      - Remove all Classic Mode bean definitions from DataFlowControllerAutoConfiguration and TestDependecies
      - Remove Skipper feature and all its occurrences and checks. Now all previous skipper related configurations are subject of the Stream Feature policies.
      - The StreamControllerTests#testDeployWithWildcardProperties demonstrates how to use the skipperClient mock and UploadRequest and InstallRequest to verify the Stream Creation and Deployment behavior without relying on local app deployer
      - Removed classes:
         AppDeployerStreamDeployer, AppDeployerStreamDeployerTests
         AppDeployerStreamService
         AppDeployerStreamServiceTests
         AppRegistry, AppRegistryTests
         AppRegistryController, AppRegistryControllerTests
         ClassicAppRegistryCommands, ClassicAppRegistryCommandsTests, ClassicStreamCommands
         ConditionalOnSkipperDisabled, ConditionalOnSkipperEnabled
         DataFlowMode, IncompatibleDataFlowMode
         org.springframework.cloud.dataflow.shell.command.classic Package
         RdbmsUriRegistry, RdbmsUriRegistryTests
         RedisUriRegistry

    - Resolve Jackson2HalModule configuration
    - Remove redundant,  classic-mode classes.
    - Improve test coverage.
    - mock skipper client for tests

    • pom.xml (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-classic-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation/AboutDocumentation.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-classic-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation/ApiDocumentation.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-classic-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation/BaseDocumentation.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-classic-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation/RuntimeAppsDocumentation.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-completion/src/test/java/org/springframework/cloud/dataflow/completion/BootVersionsCompletionProviderTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-completion/src/test/java/org/springframework/cloud/dataflow/completion/CompletionTestsMocks.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-completion/src/test/java/org/springframework/cloud/dataflow/completion/StreamCompletionProviderTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-completion/src/test/java/org/springframework/cloud/dataflow/completion/TaskCompletionProviderTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/AppRegistry.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/AppRegistryCommon.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/RdbmsUriRegistry.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/RedisUriRegistry.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/domain/AppRegistration.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/main/java/org/springframework/cloud/dataflow/registry/support/AppResourceCommon.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/test/java/org/springframework/cloud/dataflow/registry/AppRegistryTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/test/java/org/springframework/cloud/dataflow/registry/service/DefaultAppRegistryServiceTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/test/java/org/springframework/cloud/dataflow/registry/support/AppResourceCommonTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-registry/src/test/resources/org/springframework/cloud/dataflow/registry/service/AppRegistryTests-importAll.properties (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-rest-client/src/main/java/org/springframework/cloud/dataflow/rest/client/DataFlowTemplate.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-rest-resource/src/main/java/org/springframework/cloud/dataflow/rest/resource/about/FeatureInfo.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/ConditionalOnSkipperDisabled.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/ConditionalOnSkipperEnabled.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/config/DataFlowControllerAutoConfiguration.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/config/features/FeaturesProperties.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/config/features/StreamConfiguration.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/AboutController.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/AppRegistryController.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/RootController.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/SkipperAppRegistryController.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/SkipperStreamDeploymentController.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/repository/IncompatibleStreamDeployerException.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/repository/RdbmsStreamDeploymentRepository.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/repository/StreamDeploymentRepository.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/AbstractStreamService.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/AppDeployerStreamService.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/AppDeploymentRequestCreator.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskService.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/stream/AppDeployerStreamDeployer.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/stream/StreamDeployers.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/completion/TabOnTapCompletionProviderTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/config/DataFlowServerConfigurationTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/configuration/JobDependencies.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/configuration/TaskServiceDependencies.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/configuration/TestDependencies.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/AboutControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/AppRegistryControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/AuditRecordControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/CompletionControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/RootControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/RuntimeAppsControllerSkipperTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/RuntimeAppsControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/SkipperAppRegistryControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/StreamControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/StreamDeploymentControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/TaskControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/TaskSchedulerControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/ToolsControllerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/registry/DataFlowAppRegistryPopulator.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/registry/RdbmsUriRegistryTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/repository/DeploymentKeyTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/repository/InMemoryStreamDeploymentRepository.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/AppDeployerStreamServiceTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/AppDeploymentRequestCreatorTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/DefaultSchedulerServiceTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/DefaultSkipperStreamServiceIntegrationTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/DefaultSkipperStreamServiceTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/DefaultSkipperStreamServiceUpdateTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/DefaultSkipperStreamServiceUpgradeStreamTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskServiceTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/validation/DefaultAppValidationServiceTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/stream/AppDeployerStreamDeployerTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-server-core/src/test/resources/register-all.txt (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/DataFlowMode.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/IncompatibleDataFlowMode.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/Target.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/autoconfigure/BaseShellAutoConfiguration.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/classic/ClassicAppRegistryCommands.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/classic/ClassicStreamCommands.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/classic/package-info.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/command/common/ConfigCommands.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/main/java/org/springframework/cloud/dataflow/shell/config/ShellCommandLineConfiguration.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/AbstractShellIntegrationTest.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/ClassicAppRegistryCommandsTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/ConfigCommandTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/JobCommandTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/ShellCommandsTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/StreamCommandTemplate.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/StreamCommandTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/java/org/springframework/cloud/dataflow/shell/command/TaskCommandTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-shell-core/src/test/resources/org/springframework/cloud/dataflow/shell/command/ConfigCommandTests-testInfo.txt (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-dataflow-skipper-docs/src/test/java/org/springframework/cloud/dataflow/server/rest/documentation/BaseSkipperDocumentation.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/LocalConfigurationTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/LocalDataflowResource.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/security/LocalServerSecurityRootWithUsersFileTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/security/LocalServerSecurityWithSingleUserTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • spring-cloud-starter-dataflow-server-local/src/test/java/org/springframework/cloud/dataflow/server/local/security/LocalServerSecurityWithUsersFileTests.java (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)
    • src/checkstyle/checkstyle.xml (version 3f0737c9e5549aa7746c91675cde9a7698429e5e)