Build: #5 was successful Changes by Ilayaperumal Gopinathan and Christian Tzolov

Stages & jobs

  1. Default Stage

  2. Build Data Admin Docker Image and upload

Code commits

Git

  • Ilayaperumal Gopinathan

    Ilayaperumal Gopinathan bb22eabcb2bed50b2d973764e2d1eb47eb7e1353

    Fix ArgumentSanitizer for stream def
     - Shouldn't persist sanitized version of stream definition when updating the properties during skipper update
       - Remove test method that checks for sanitized stream definition from database
     - Fix regex to handle dots and dashes in the stream definition string
     - Add test

    Resolves #2185

    • spring-cloud-dataflow-server-core/src/test/resources/org/springframework/cloud/dataflow/server/service/impl/DefaultSkipperStreamServiceIntegrationTests-upgradeWithSensitivePropertiesManifest.yml (version bb22eabcb2bed50b2d973764e2d1eb47eb7e1353)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/support/ArgumentSanitizerTest.java (version bb22eabcb2bed50b2d973764e2d1eb47eb7e1353)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/service/impl/DefaultSkipperStreamServiceIntegrationTests.java (version bb22eabcb2bed50b2d973764e2d1eb47eb7e1353)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultSkipperStreamService.java (version bb22eabcb2bed50b2d973764e2d1eb47eb7e1353)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/support/ArgumentSanitizer.java (version bb22eabcb2bed50b2d973764e2d1eb47eb7e1353)
  • Christian Tzolov

    Christian Tzolov 6d7a1e7889dd85e00ce57d2fba1957be457f8057

    Incorrect Stream properties sanitizing
    Resolves #2196
    for 1.5.0 branch

     - Parse/process Stream's DSL using the java API (e.g. StreamDefinition, StreamAppDefinition) instead of incomplete regular expressions.
     - Fix the affected tests

    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/support/ArgumentSanitizerTest.java (version 6d7a1e7889dd85e00ce57d2fba1957be457f8057)
    • spring-cloud-dataflow-server-core/src/test/java/org/springframework/cloud/dataflow/server/controller/StreamControllerTests.java (version 6d7a1e7889dd85e00ce57d2fba1957be457f8057)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/support/ArgumentSanitizer.java (version 6d7a1e7889dd85e00ce57d2fba1957be457f8057)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/StreamDeploymentController.java (version 6d7a1e7889dd85e00ce57d2fba1957be457f8057)
    • spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/controller/StreamDefinitionController.java (version 6d7a1e7889dd85e00ce57d2fba1957be457f8057)