Build #7,547

Build: #7547 failed Changes by Phil Webb

Build result summary

Details

Completed
Duration
8 minutes
Labels
None
Agent
bamboo-15.af.pivotal.io
Revisions
Spring Framework
932f771380db98f80c75ccb16cd122db1bfdc970 932f771380db98f80c75ccb16cd122db1bfdc970
Plan Repository
932f771380db98f80c75ccb16cd122db1bfdc970 932f771380db98f80c75ccb16cd122db1bfdc970
Total tests
19071
Fixed in
#7549 (Manual run by Sam Brannen)

Tests

Responsible

Code commits

Spring Framework
Author Commit Message Commit date
Phil Webb Phil Webb 932f771380db98f80c75ccb16cd122db1bfdc970 932f771380db98f80c75ccb16cd122db1bfdc970 Improve performance of FormContentFilter
Improve the performance of `FormContentFilter` by checking directly if
`contentType` is empty. This saves the need for an exception to thrown
then immediately caught.

Closes gh-23216
Phil Webb Phil Webb b3d56ebf3b2dae906d13ae5cdd7f23b8945f3d85 b3d56ebf3b2dae906d13ae5cdd7f23b8945f3d85 Restore StringUtils.hasLength check
Update `MimeTypeUtils` so that the  StringUtils.hasLength check is
performed immediately on the incoming argument, rather than in
`parseMimeTypeInternal`. This restores the `IllegalArgumentException`
rather than the `NullPointerException` which is thrown by the
`ConcurrentHashMap`.

Closes gh-23215
See gh-23211
Plan Repository
Author Commit Message Commit date
Phil Webb Phil Webb 932f771380db98f80c75ccb16cd122db1bfdc970 932f771380db98f80c75ccb16cd122db1bfdc970 Improve performance of FormContentFilter
Improve the performance of `FormContentFilter` by checking directly if
`contentType` is empty. This saves the need for an exception to thrown
then immediately caught.

Closes gh-23216
Phil Webb Phil Webb b3d56ebf3b2dae906d13ae5cdd7f23b8945f3d85 b3d56ebf3b2dae906d13ae5cdd7f23b8945f3d85 Restore StringUtils.hasLength check
Update `MimeTypeUtils` so that the  StringUtils.hasLength check is
performed immediately on the incoming argument, rather than in
`parseMimeTypeInternal`. This restores the `IllegalArgumentException`
rather than the `NullPointerException` which is thrown by the
`ConcurrentHashMap`.

Closes gh-23215
See gh-23211

Tests

New test failures 1
Status Test View job Duration
Collapse Failed MultipartIntegrationTests transferTo[server [org.springframework.http.server.reactive.bootstrap.UndertowHttpServer@5676c4cc]] History
Default Job < 1 sec
org.junit.ComparisonFailure: org.junit.ComparisonFailure: expected:<[[76, 111, 114, 101, 109, 32, 73, 112, 115, 117, 109, 46]]> but was:<[[-119, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, 82, 0, 0, 1, -112, 0, 0, 1, -112, 8, 6, 0, 0, 0, -128, -65, 54, -52, 0, 0, 32, 0, 73, 68, 65, 84, 120, 1, -20, -63, -3, 115, 28, -121, 125, -25, -7, -9, 103, 102, 48, 3, 76, 55, 0, 62, 75, -42, -93, -83, 7, 39, 126, 82, 28, -101, -92, -84, 40, 57, 107, -9, -30, -115, 53, -105, -11, 99, -74, 68, -50, 84, 109, -35, 85, -35, 85, 93, -4, -37, -42, -83, 66, -78, 111, -123, -18, -95, 10, 28, 42, 85, -9, 55, 92, -18, 7, 12, -87, -13, -70, -14, 120, 78, -20, 56, -114, -97, -12, 100, -39, 73, 44, -38, -119, 8, -46, -111, 101, 75, 34, 41, 82, -108, 0, 116, 3, -104, -57, -17, -11, 76, 3, 32, -8, 20, 11, 3, -127, -106, -60, 126, -67, -28, -108, 72, -91, 82, -87, -44, 117, 36, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -111, 74, -91, 82, -87, -21, 72, 20, -126, -29, -126, 87, -10, -15, 42, 1, -125, -110, 83, 34, -107, 74, -91, 82, -41, -111, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, 68, 42, -107, 74, -91, -82, 35, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -87, 84, 42, -107, -70, -114, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, 82, -87, 84, 42, 117, 29, -119, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -92, 82, -87, 84, -22, 58, 18, -123, -32, -72, -32, -107, 125, -68, 74, -64, -96, -28, -108, 72, -91, 82, -87, -44, 117, 36, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -111, 74, -91, 82, -87, -21, 72, 20, -126, -29, -126, 87, -10, -15, 42, 1, -125, -110, 83, 34, -107, 74, -91, 82, -41, -111, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, 68, 42, -107, 74, -91, -82, 35, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -87, 84, 42, -107, -70, -114, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, 82, -87, 84, 42, 117, 29, -119, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -92, 82, -87, 84, -22, 58, 18, -123, -32, -72, -32, -107, 125, -68, 74, -64, -96, -28, -108, 72, -91, 82, -87, -44, 117, 36, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -111, 74, -91, 82, -87, -21, 72, 20, -126, -29, -126, 87, -10, -15, 42, 1, -125, -110, 83, 34, -107, 74, -91, 82, -41, -111, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, 68, 42, -107, 74, -91, -82, 35, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -87, 84, 42, -107, -70, -114, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, -34, 18, -117, 77, -24, 52, 1, 3, 68, 42, -107, 74, -91, 126, 85, 12, 16, 100, -13, 48, -100, -25, 50, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -21, -78, -40, -124, -31, 60, -4, -50, 71, 62, -55, -17, 124, -28, 1, 10, -7, 97, 26, -51, 69, 82, -87, 84, 42, -11, -85, 81, -56, 15, -45, 104, 46, -14, -99, 99, -33, -30, 123, -57, -66, -51, 98, 19, -122, -13, -84, -120, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -84, 75, 20, -126, -29, -126, 87, -10, -15, 42, 1, -87, 84, 42, -107, 122, 123, -104, -100, 10, -88, -43, -85, 68, 33, 56, 46, 43, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -21, 18, -51, -127, 51, 10, -43, -1, -71, -58, -1, -15, -97, -10, -109, 74, -91, 82, -87, -73, -121, -1, -21, -53, -121, -15, -1, -28, 0, -47, 28, 56, -93, -84, -120, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -84, 75, 20, -126, -29, -126, 87, -10, -15, 42, 1, -87, 84, 42, -107, 122, 123, -104, -100, 10, -88, -43, -85, 68, 33, 56, 46, 43, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -21, 18, -123, -32, -72, -32, -107, 125, -68, 74, 64, 42, -107, 74, -91, -34, 30, 38, -89, 2, 106, -11, 42, 81, 8, -114, -53, -118, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, -60, -70, 68, 33, 56, 46, 120, 101, 31, -81, 18, -112, 74, -91, 82, -87, -73, -121, -55, -87, -128, 90, -67, 74, 20, -126, -29, -78, 34, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -79, 46, 81, 8, -114, 11, 94, -39, -57, -85, 4, -68, 89, 102, -122, 36, 82, -87, 84, -22, 122, 103, 102, 72, -30, -83, 54, 57, 21, 80, -85, 87, -119, 66, 112, 92, 86, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, -42, 37, 10, -63, 113, -63, 43, -5, 120, -107, -128, 84, 42, -107, 74, -67, 61, 76, 78, 5, -44, -22, 85, -94, 16, 28, -105, 21, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 117, -119, 66, ...]]>
org.junit.ComparisonFailure: expected:<[[76, 111, 114, 101, 109, 32, 73, 112, 115, 117, 109, 46]]> but was:<[[-119, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, 82, 0, 0, 1, -112, 0, 0, 1, -112, 8, 6, 0, 0, 0, -128, -65, 54, -52, 0, 0, 32, 0, 73, 68, 65, 84, 120, 1, -20, -63, -3, 115, 28, -121, 125, -25, -7, -9, 103, 102, 48, 3, 76, 55, 0, 62, 75, -42, -93, -83, 7, 39, 126, 82, 28, -101, -92, -84, 40, 57, 107, -9, -30, -115, 53, -105, -11, 99, -74, 68, -50, 84, 109, -35, 85, -35, 85, 93, -4, -37, -42, -83, 66, -78, 111, -123, -18, -95, 10, 28, 42, 85, -9, 55, 92, -18, 7, 12, -87, -13, -70, -14, 120, 78, -20, 56, -114, -97, -12, 100, -39, 73, 44, -38, -119, 8, -46, -111, 101, 75, 34, 41, 82, -108, 0, 116, 3, -104, -57, -17, -11, 76, 3, 32, -8, 20, 11, 3, -127, -106, -60, 126, -67, -28, -108, 72, -91, 82, -87, -44, 117, 36, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -111, 74, -91, 82, -87, -21, 72, 20, -126, -29, -126, 87, -10, -15, 42, 1, -125, -110, 83, 34, -107, 74, -91, 82, -41, -111, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, 68, 42, -107, 74, -91, -82, 35, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -87, 84, 42, -107, -70, -114, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, 82, -87, 84, 42, 117, 29, -119, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -92, 82, -87, 84, -22, 58, 18, -123, -32, -72, -32, -107, 125, -68, 74, -64, -96, -28, -108, 72, -91, 82, -87, -44, 117, 36, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -111, 74, -91, 82, -87, -21, 72, 20, -126, -29, -126, 87, -10, -15, 42, 1, -125, -110, 83, 34, -107, 74, -91, 82, -41, -111, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, 68, 42, -107, 74, -91, -82, 35, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -87, 84, 42, -107, -70, -114, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, 82, -87, 84, 42, 117, 29, -119, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -92, 82, -87, 84, -22, 58, 18, -123, -32, -72, -32, -107, 125, -68, 74, -64, -96, -28, -108, 72, -91, 82, -87, -44, 117, 36, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -111, 74, -91, 82, -87, -21, 72, 20, -126, -29, -126, 87, -10, -15, 42, 1, -125, -110, 83, 34, -107, 74, -91, 82, -41, -111, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, 68, 42, -107, 74, -91, -82, 35, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -87, 84, 42, -107, -70, -114, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, -34, 18, -117, 77, -24, 52, 1, 3, 68, 42, -107, 74, -91, 126, 85, 12, 16, 100, -13, 48, -100, -25, 50, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 84, 42, -107, 74, 93, 71, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -21, -78, -40, -124, -31, 60, -4, -50, 71, 62, -55, -17, 124, -28, 1, 10, -7, 97, 26, -51, 69, 82, -87, 84, 42, -11, -85, 81, -56, 15, -45, 104, 46, -14, -99, 99, -33, -30, 123, -57, -66, -51, 98, 19, -122, -13, -84, -120, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -84, 75, 20, -126, -29, -126, 87, -10, -15, 42, 1, -87, 84, 42, -107, 122, 123, -104, -100, 10, -88, -43, -85, 68, 33, 56, 46, 43, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -21, 18, -51, -127, 51, 10, -43, -1, -71, -58, -1, -15, -97, -10, -109, 74, -91, 82, -87, -73, -121, -1, -21, -53, -121, -15, -1, -28, 0, -47, 28, 56, -93, -84, -120, 66, 112, 92, -16, -54, 62, 94, 37, 96, 80, 114, 74, -84, 75, 20, -126, -29, -126, 87, -10, -15, 42, 1, -87, 84, 42, -107, 122, 123, -104, -100, 10, -88, -43, -85, 68, 33, 56, 46, 43, -94, 16, 28, 23, -68, -78, -113, 87, 9, 24, -108, -100, 18, -21, 18, -123, -32, -72, -32, -107, 125, -68, 74, 64, 42, -107, 74, -91, -34, 30, 38, -89, 2, 106, -11, 42, 81, 8, -114, -53, -118, 40, 4, -57, 5, -81, -20, -29, 85, 2, 6, 37, -89, -60, -70, 68, 33, 56, 46, 120, 101, 31, -81, 18, -112, 74, -91, 82, -87, -73, -121, -55, -87, -128, 90, -67, 74, 20, -126, -29, -78, 34, 10, -63, 113, -63, 43, -5, 120, -107, -128, 65, -55, 41, -79, 46, 81, 8, -114, 11, 94, -39, -57, -85, 4, -68, 89, 102, -122, 36, 82, -87, 84, -22, 122, 103, 102, 72, -30, -83, 54, 57, 21, 80, -85, 87, -119, 66, 112, 92, 86, 68, 33, 56, 46, 120, 101, 31, -81, 18, 48, 40, 57, 37, -42, 37, 10, -63, 113, -63, 43, -5, 120, -107, -128, 84, 42, -107, 74, -67, 61, 76, 78, 5, -44, -22, 85, -94, 16, 28, -105, 21, 81, 8, -114, 11, 94, -39, -57, -85, 4, 12, 74, 78, -119, 117, -119, 66, ...]]>
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at org.springframework.web.reactive.result.method.annotation.MultipartIntegrationTests.verifyContents(MultipartIntegrationTests.java:173)
	at org.springframework.web.reactive.result.method.annotation.MultipartIntegrationTests.lambda$transferTo$5(MultipartIntegrationTests.java:163)
	at reactor.test.DefaultStepVerifierBuilder.lambda$consumeNextWith$1(DefaultStepVerifierBuilder.java:266)
(54 more lines...)