Build #7,703

Build: #7703 failed Changes by Sam Brannen

Build result summary

Details

Completed
Duration
9 minutes
Labels
None
Agent
bamboo-21.af.pivotal.io
Revisions
Spring Framework
03dd45fbd62bdc158bf31098fd54cf5de3da2026 03dd45fbd62bdc158bf31098fd54cf5de3da2026
Plan Repository
03dd45fbd62bdc158bf31098fd54cf5de3da2026 03dd45fbd62bdc158bf31098fd54cf5de3da2026
Total tests
18214
Fixed in
#7704 (Changes by Sam Brannen)

Tests

Responsible

Code commits

Spring Framework
Author Commit Message Commit date
Sam Brannen Sam Brannen 03dd45fbd62bdc158bf31098fd54cf5de3da2026 03dd45fbd62bdc158bf31098fd54cf5de3da2026 Use AssertJ in AnnotationAttributesTests
Sam Brannen Sam Brannen 34767b14da056c1f23757ba830daa256c3c8e3b6 34767b14da056c1f23757ba830daa256c3c8e3b6 Merge branch '5.1.x'
Sam Brannen Sam Brannen 30ebc3b8e2185c56791531507e0f430972f82b51 m 30ebc3b8e2185c56791531507e0f430972f82b51 Remove superfluous AnnotationAttributes#putIfAbsent implementation
Since Java 8, putIfAbsent() is a standard method in java.util.Map. We
therefore no longer need the custom implementation that overrides the
standard implementation in HashMap.
Sam Brannen Sam Brannen a092dc055e1d773f63f500e7cb6237ee44567b31 m a092dc055e1d773f63f500e7cb6237ee44567b31 Check for instanceof Throwable in AnnotationAttributes#assertNotException
Prior to this commit, AnnotationAttributes#assertNotException checked if
the attribute value was an instance of Exception. Although this was
typically sufficient, the scope was not always broad enough -- for
example, if AnnotationReadingVisitorUtils#convertClassValues stored a
Throwable in the map (such as a LinkageError).

This commit fixes this by checking for an instance of Throwable in
AnnotationAttributes#assertNotException.

Closes gh-23424
Plan Repository
Author Commit Message Commit date
Sam Brannen Sam Brannen 03dd45fbd62bdc158bf31098fd54cf5de3da2026 03dd45fbd62bdc158bf31098fd54cf5de3da2026 Use AssertJ in AnnotationAttributesTests

Tests

New test failures 1
Status Test View job Duration
Collapse Failed WebSocketIntegrationTests echo[client[org.springframework.web.reactive.socket.client.JettyWebSocketClient@1e961b38] - server [org.springframework.http.server.reactive.bootstrap.TomcatHttpServer@47153050]] History
Default Job 5 secs
java.lang.IllegalStateException: java.lang.IllegalStateException: Timeout on blocking read for 5000 MILLISECONDS
java.lang.IllegalStateException: Timeout on blocking read for 5000 MILLISECONDS
	at reactor.core.publisher.BlockingSingleSubscriber.blockingGet(BlockingSingleSubscriber.java:117)
	at reactor.core.publisher.Mono.block(Mono.java:1538)
	at org.springframework.web.reactive.socket.WebSocketIntegrationTests.echo(WebSocketIntegrationTests.java:71)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(76 more lines...)