Build #652

Build: #652 was successful Changes by Sam Brannen

Build result summary

Details

Completed
Duration
14 minutes
Labels
None
Agent
bamboo-18.af.pivotal.io
Revision
f60bb825b08038cb869d9a73a07bd19b97b7e9dc f60bb825b08038cb869d9a73a07bd19b97b7e9dc
Total tests
16832
Successful since
#647 ()

Tests

Code commits

Author Commit Message Commit date
Sam Brannen Sam Brannen f60bb825b08038cb869d9a73a07bd19b97b7e9dc f60bb825b08038cb869d9a73a07bd19b97b7e9dc Retain brackets for IPV6 address in MockHttpServletRequest
According to the Javadoc for ServletRequest's getServerName() method,
when the `Host` header is set, the server name is "the value of the
part before ':' in the Host header value ...". For a value representing
an IPV6 address such as `[::ffff:abcd:abcd]`, the enclosing square
brackets should therefore not be stripped from the enclosed IPV6
address.

However, the changes made in conjunction with gh-16704 introduced a
regression in Spring Framework 4.1 for the getServerName() method in
MockHttpServletRequest by stripping the enclosing brackets from the
IPV6 address in the `Host` header. Similarly, the changes made in
conjunction with gh-20686 introduced a regression in Spring Framework
4.3.13 and 5.0.2 in the getRequestURL() method in
MockHttpServletRequest by delegating to the getServerName() method
which strips the enclosing brackets.

This commit fixes the implementation of getServerName() so that the
enclosing brackets are no longer stripped from an IPV6 address in the
`Host` header. The implementation of getRequestURL() is therefore also
fixed.

In addition, in order to avoid a NullPointerException, the
implementations of getServerName() and getServerPort() now assert that
an IPV6 address present in the `Host` header correctly contains an
opening and closing bracket and throw an IllegalStateException if that
is not the case.

Closes gh-24916