Build #2

Build: #2 was successful Code changes detected

Build result summary

Details

Completed
Duration
2 minutes
Labels
None
Agent
bamboo-05.af.pivotal.io
Revision
b61f98fbed11da4876440a30fb914f0fea66fdde b61f98fbed11da4876440a30fb914f0fea66fdde
Total tests
1388
Successful since
#1 ()

Code commits

Author Commit Message Commit date
Jens Schauder <jschauder@pivotal.io> Jens Schauder <jschauder@pivotal.io> b61f98fbed11da4876440a30fb914f0fea66fdde m b61f98fbed11da4876440a30fb914f0fea66fdde DATAJPA-1105 - Fixed support for nested IdClass with non mapped non primitive type.
When obtaining a multipart id from an entity we have to check for each part of the id if it is another entity.

Before this change that check was done be checking if the type is a primitive or wrapper type, which fails to properly classify e.g. String.
This caused us to try to get an id from a String instance which of course failed because String is not a managed type.

Now we make the necessary distinction based on JpaMetamodel.isJpaManaged(type).

Changes in the persistence.xml beyond adding entities for tests are required to make the tests work again with EclipseLink.
This didn't cause problems in the past because all tests that actually access the database and use the changed persistence context are disabled for EclipseLink.

The new test had to be get disabled for EclipseLink though, due to another bug in EclipseLink which prevents the usage of inner classes in @IdClass annotations.

See also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=531528

JIRA issues

IssueDescriptionStatus
Unknown Issue TypeDATAJPA-1105Could not obtain issue details from JIRA