https://github.com/SpringSource/spring-xd

Build: #2236 failed Changes by 3 people

Build result summary

Details

Completed
Duration
207 minutes
Labels
None
Revision
2180cdcf5537ba8cc763f71ab8245ef6be7fbe22 2180cdcf5537ba8cc763f71ab8245ef6be7fbe22
Total tests
725
Fixed in
#2237 (Changes by Marius Bogoevici <mbogoevici@pivotal.io>)

Tests

Responsible

  • mbg_at_pivotal mbg_at_pivotal Automatically assigned

Code commits

Author Commit Message Commit date
Marius Bogoevici <mbogoevici@pivotal.io> Marius Bogoevici <mbogoevici@pivotal.io> 2180cdcf5537ba8cc763f71ab8245ef6be7fbe22 2180cdcf5537ba8cc763f71ab8245ef6be7fbe22 XD-2996: Align Kafka Partitioning/XD Partitioning
JIRA: XD-2996">https://jira.spring.io/browse/XD-2996

Align transport native partitioning with Spring XD partitioning

- Eliminate the `partitionCount` property, which is currently just a copy of `count`, as well as its calculation;
- Propagate `nextModuleCount` and `nextModuleConcurrency` to all non-last modules;
- Make the target partition count an argument for the construction of `PartitioningMetadata`, and defer to the transport-specific implementation to decide on the value to be used: Redis and Rabbit will simply use `nextModuleCount`, and Kafka will use the partition count of the target topic;
- the number of the partitions used by the Kafka bus is the larger of `minPartitionCount` and `nextModuleConcurrency` * `nextModuleCount`, unless a topic exists and already has more partitions than either of the two values, case in which the number of existing partitions will be used;
- eliminate the additional calculation in the Kafka bus, which was required because the number of Spring XD partitions, could have been, in principle, different from the number of underlying Kafka partitions;
- unit tests adjustments;
Gunnar Hillert Gunnar Hillert 70866a5fed9c6abcdda33cb05e5ab7a09cfa40ad 70866a5fed9c6abcdda33cb05e5ab7a09cfa40ad XD-3112 Mask passwords in stream defs/modules
* Mask passwords when returning streams via the REST-API
* Add test

XD-3112 Fix tests

XD-3112 Add password masking for `/runtime/modules`
Eric Bottard Eric Bottard 06863c3a54625ecd2c125369572f1ad6561efcb3 06863c3a54625ecd2c125369572f1ad6561efcb3 XD-3116: Update bundled redis to 3.0.1

Tests

New test failures 1
Status Test View job Duration
Collapse Failed KafkaSingleNodeStreamDeploymentIntegrationTests deployAndUndeploy History
Default Job 1 min
java.lang.AssertionError: java.lang.AssertionError: stream test4 (BaseDefinition [definition=http --port=49708| transform --expression=payload | filter --expression=true | log, name=test4]) not deployed
java.lang.AssertionError: stream test4 (BaseDefinition [definition=http --port=49708| transform --expression=payload | filter --expression=true | log, name=test4]) not deployed
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.springframework.xd.dirt.stream.AbstractSingleNodeStreamDeploymentIntegrationTests.deployAndUndeploy(AbstractSingleNodeStreamDeploymentIntegrationTests.java:360)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
(44 more lines...)

Jira issues

IssueDescriptionStatus
Unknown Issue TypeXD-2996Could not obtain issue details from Jira
Unknown Issue TypeXD-3112Could not obtain issue details from Jira
Unknown Issue TypeXD-3116Could not obtain issue details from Jira